Query Service AIO #467
Merged
Query Service AIO #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌋 Here are results of SLO test for python-sync: |
vgvoleg
force-pushed
the
query_service_async
branch
2 times, most recently
from
b72d422 to
a5870d9
Compare
vgvoleg
force-pushed
the
query_service_async
branch
from
ff3ddcc to
8f654cb
Compare
rekby
reviewed
Aug 13, 2024
| async for result_set in results: | ||
| print(f"rows: {str(result_set.rows)}") | ||
|
|
||
| await pool.retry_operation_async(callee) |
There was a problem hiding this comment.
Is it possible to use execute_with_retries?
vgvoleg
force-pushed
the
query_service_async
branch
from
8f654cb to
52a6bfd
Compare
rekby
reviewed
Aug 14, 2024
| @@ -0,0 +1,143 @@ | |||
| import asyncio | |||
| async for result_set in results: | ||
| print(f"rows: {str(result_set.rows)}") | ||
|
|
||
| await pool.retry_operation_async(callee) |
ydb/aio/query/session.py
Outdated
| self._state.reset() | ||
| self._state._change_state(QuerySessionStateEnum.CLOSED) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Do you need to change state of the session on exception?
Do you need same behaviour for sync method?
| self._tx_state._change_state(QueryTxStateEnum.ROLLBACKED) | ||
| return | ||
|
|
||
| await self._ensure_prev_stream_finished() |
There was a problem hiding this comment.
The method override base method, but with other signature.
It is difference from sync class: sync class use method from base class.
What about do one of:
- Extract common part to base class and reuse it from both children
- Complete split method to sync and async - for same style.
Now I can fix bug in the base class and think about I fix the bug/change behaviour in both variants because it is base class. (Or forgot about async code at all).
Same for other methods from the base class.
rekby
reviewed
Aug 15, 2024
| @@ -58,7 +58,9 @@ async def _check_session_status_loop(self) -> None: | |||
| self._state.reset() | |||
| self._state._change_state(QuerySessionStateEnum.CLOSED) | |||
| except Exception: | |||
| pass | |||
| if not self._state._already_in(QuerySessionStateEnum.CLOSED): | |||
| self._state.reset() | |||
There was a problem hiding this comment.
- Why do you need reset session state before set closed _state._state?
- When the session will be really closed (call
DeleteSessionand detach from attached stream?
rekby
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information